The reset column filter functionality is broken when the datagrid is nested inside another component #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent is nested inside another component.
|
@paveljanda @f3l1x What do you think? I would love to see that in the 5.7.* versions since I consider that a bug and because there are still people (inluding me) who cannot yet update to nette 3.0. |
|
What do you think @paveljanda? |
|
All this code was added because older (I am not sure whether it still happens in newer versions) nette versions did not behave exactly as intended - speaking about snippets. To merge this PR, it would require a thorough testing across multiple nette versions and all possible scenarious with both this and without this PR. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reset column filter functionality is broken, when the datagrid component is nested inside another component.
Just to be clear, it is the X link in the table heading (screen included)
So, the proposed solution is as follows.
I've removed the JS code, that changes the URL of the link to delete the filter on a column. The comment said that the code is there because table header is not refreshed using snippets. So, I've added the snippet to the
theadelement. Next, the snippet is invalidated in the\Ublaboo\DataGrid\DataGrid::reload()method.Basically, I wonder why it was originally done that way and not via the snippet invalidation.
I've tested that change for grid, which is directly attached to the presenter as well as grid inside another component and it seems to be working just fine. i don't think this could cause any issue other than slightly bigger network traffic.